Improve toolbar styles for small screens #4342
Conversation
tomaskikutis
changed the base branch from
develop
to
authoring-react-post-broadcasting
| @@ -396,7 +396,7 @@ class Monitoring { | |||
| this.tabAction = function(tab) { | |||
| const btn = element(by.css('[ng-click="vm.current_tab = \'' + tab + '\'"]')); | |||
|
|
|||
| browser.wait(ECE.elementToBeClickable(btn), 2000); | |||
| browser.wait(ECE.elementToBeClickable(btn)); | |||
There was a problem hiding this comment.
this will make it wait for minutes before failing, not sure that's useful in general
|
|
||
| const templateBtn = el(['content-create-dropdown']).element(by.buttonText('editor3 template')); | ||
|
|
||
| browser.wait(ECE.elementToBeClickable(templateBtn)); |
There was a problem hiding this comment.
would be good also to add explicit time to wait
|
I think we should control it via a default timeout so we don't have to pass it every time. 5 seconds would probably be fine in most cases. If I were to set it tests would probably start timing out on the instance and not locally as it is already happening to an extent and I can't understand the problem. Whether github virtual machine has resource limited or protractor is buggy or a combination of the 2. My idea is that we keep it on life support for now and when you finish back-end for DB snapshots we start moving tests to another framework which is more stable and where we can set ~5 second default timeout. Do you have other ideas? |
|
problem is that default timeout is also used for the whole spec. switching to a different framework makes sense, protractor is EOLed |
Interesting, I didn't know that. I'd be reasonable then to make a constant for a single action and always pass it, but given that we'll be moving to another framework I don't think it's worth investing the time now to go over all |
|
yep I wouldn't go over all, just would pass something to new ones and not remove it from existing |
tomaskikutis
merged commit bc85cfd
into
superdesk:authoring-react-post-broadcasting
SDESK-7058
before
after